Draft
Conversation
tuj
reviewed
Aug 30, 2025
| @@ -0,0 +1,70 @@ | |||
| // Load templates. | |||
Contributor
There was a problem hiding this comment.
Any reason for splitting into template-admin template-slide ?
Contributor
Author
There was a problem hiding this comment.
You mean, not putting them in the same file?
Contributor
There was a problem hiding this comment.
Yes.. they are almost duplicates.
Contributor
Author
There was a problem hiding this comment.
Yes, would you prefer one file to do both? At first they were in the same file but I though the slight differences made it more messy so i split them.
sinejespersen
force-pushed
the
feature/5316-poc-admin-form
branch
from
0f134e9 to
3c9fe8f
Compare
sinejespersen
force-pushed
the
feature/5316-poc-admin-form
branch
from
39069ca to
ac5bcd9
Compare
sinejespersen
force-pushed
the
feature/5316-poc-admin-form
branch
from
0c8278a to
bdd5cb5
Compare
sinejespersen
force-pushed
the
feature/5316-poc-admin-form
branch
from
586461b to
203b7cd
Compare
sinejespersen
force-pushed
the
feature/5316-poc-admin-form
branch
from
2ac7785 to
324eebb
Compare
sinejespersen
force-pushed
the
feature/5316-poc-admin-form
branch
from
324eebb to
0a641eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#267
Ticket
https://leantime.itkdev.dk/#/tickets/showTicket/5316
https://leantime.itkdev.dk/#/tickets/showTicket/6501
Description
Add option of defining the template admin form as React component instead of through a static json array.
helper.jsforgetInputFilesrenderAdminFormlike already existingrenderSlideadminForminimage-text.jsonadmin-form.jsxwith the admin form in, add a bit of if/then in the jsx.image-text.jsxScreenshot of the result