Open
Conversation
alisa911
reviewed
Feb 20, 2026
alisa911
reviewed
Feb 27, 2026
| ctx.setTracksGroups([...trackGroups, ...smartFolders]); | ||
| } else { | ||
| ctx.setTracksGroups([]); | ||
| const smartFolders = ctx.tracksGroups?.filter((g) => g.type === SMART_TYPE) || []; |
Contributor
There was a problem hiding this comment.
There are empty groups here where smartFolders come from.
| }); | ||
|
|
||
| setTracksGroups((prev) => { | ||
| const withoutSmartFolders = prev.filter((g) => g.type !== SMART_TYPE); |
alisa911
reviewed
Mar 3, 2026
Contributor
alisa911
left a comment
alisa911
left a comment
There was a problem hiding this comment.
Check all comments, close the ones that are no longer relevant or fix them.
| let minMs = Infinity; | ||
| let minDate = null; | ||
|
|
||
| (smartFolder.userFilePaths ?? []).forEach((path) => { |
Contributor
There was a problem hiding this comment.
Why not sort the files on the backend?
| async function getSmartFolders() { | ||
| const res = await apiGet(`${process.env.REACT_APP_USER_API_SITE}/mapapi/create-smart-folders`, {}); | ||
| if (res.ok) { | ||
| return res.json(); |
| } else { | ||
| setPopulatedGroup(group); | ||
| } | ||
| }, [openActions, group, ctx.listFiles?.uniqueFiles]); |
Contributor
There was a problem hiding this comment.
The list of files for filters should only be fetched when a specific folder is opened. The cache should be stored after the first read, and cleared only when either listFiles changes or the context is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1329