Update of gitignore to exclude output files#373
Open
seanfuture wants to merge 2 commits intoosmc:masterfrom
Open
Update of gitignore to exclude output files#373seanfuture wants to merge 2 commits intoosmc:masterfrom
seanfuture wants to merge 2 commits intoosmc:masterfrom
Conversation
Contributor
|
Hi Thanks for the PR. You should squash the merge commit. I've seen a couple of your comments on GitHub and it looks like you might be interested in contributing to OSMC. If that's the case, let me know. There's a lot of low hanging fruit in the build system, but time pushes things back, particularly when the benefits are not always seen by our users. Looking at my notes from September, some thoughts I had:
This is a bit loose, and there's plenty to be fleshed out, but happy to elaborate and discuss if you want to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open to suggestions as to how to best handle - thanks