Skip to content

Conversation

@sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@sschuberth sschuberth requested a review from a team as a code owner November 18, 2025 21:40
@sschuberth sschuberth enabled auto-merge (rebase) November 18, 2025 21:40
@sschuberth
Copy link
Member Author

FYI @mafibdr, this should solve your issue in a generic way.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.38%. Comparing base (5c6f16e) to head (1438bc4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nagers/maven/src/main/kotlin/utils/MavenSupport.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11102   +/-   ##
=========================================
  Coverage     57.38%   57.38%           
  Complexity     1701     1701           
=========================================
  Files           346      346           
  Lines         12833    12825    -8     
  Branches       1218     1214    -4     
=========================================
- Hits           7364     7360    -4     
+ Misses         4999     4997    -2     
+ Partials        470      468    -2     
Flag Coverage Δ
funTest-external-tools 13.48% <0.00%> (+0.01%) ⬆️
funTest-no-external-tools 31.06% <0.00%> (-0.01%) ⬇️
test-ubuntu-24.04 42.45% <0.00%> (+0.02%) ⬆️
test-windows-2025 42.43% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Instead of spreading hard-coded Spring-specific logic for package
metadata across managers, use a central Spring-specific curation provider
that creates curations on-the-fly depending on the input packages.

The plan is to add more such "calculated curations" for Spring going
forward.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth force-pushed the spring-pkg-curation-prov branch from 100044e to f6edf58 Compare November 19, 2025 07:22
Use the GitHub API to look up Spring Boot project paths. These paths do
not follow a clear pattern and vary depending on the version.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth force-pushed the spring-pkg-curation-prov branch from f6edf58 to 1438bc4 Compare November 19, 2025 08:23
Copy link
Member

@MarcelBochtler MarcelBochtler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this approach :)

@sschuberth sschuberth merged commit be610e3 into main Nov 19, 2025
32 of 34 checks passed
@sschuberth sschuberth deleted the spring-pkg-curation-prov branch November 19, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants