Skip to content

Add unit tests for ActiveBuzzerHelper#346

Open
DINES-04 wants to merge 2 commits intooss-slu:mainfrom
DINES-04:test/active-buzzer-enhancement
Open

Add unit tests for ActiveBuzzerHelper#346
DINES-04 wants to merge 2 commits intooss-slu:mainfrom
DINES-04:test/active-buzzer-enhancement

Conversation

@DINES-04
Copy link
Copy Markdown

Summary

  • Added comprehensive unit tests for all methods in ActiveBuzzerHelper in the Test folder
  • Mocked Pi4J Pwm interface to simulate hardware
  • Verified actBuzzCheck flag, tone timing, and signal toggling
  • Used LogCaptor to assert expected SLF4J logs
  • Preserved original source structure and documentation tags

Tested

mvn test passes locally

Reviewer Notes

Please check:

  • Method call order validation (InOrder)
  • Logging assertions
  • Test naming and organization

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

@yrlmanoharreddy yrlmanoharreddy self-requested a review July 21, 2025 01:24
Copy link
Copy Markdown
Collaborator

@yrlmanoharreddy yrlmanoharreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name and file name should match for consistency and to follow Java conventions. In your case, they are different—please update the file name or class name accordingly to resolve this. Check the old test cases class and make the modification similar. Thank you for your interest. And also make sure your branch is upto date with main.

@leandrumartin
Copy link
Copy Markdown
Collaborator

If you're still open to continue working on this @DINES-04, I've taken over as the lead for the project and can help answer any questions you might have.

@DINES-04
Copy link
Copy Markdown
Author

DINES-04 commented Sep 7, 2025

Sure sir

@leandrumartin leandrumartin linked an issue Sep 7, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write Unit Tests for ActiveBuzzerHelper

5 participants