Open
Conversation
pi4micronaut-utils/src/test/java/com/opensourcewithslu/outputdevices/ActiveBuzzerHelper.java
Show resolved
Hide resolved
pi4micronaut-utils/src/test/java/com/opensourcewithslu/outputdevices/ActiveBuzzerHelper.java
Show resolved
Hide resolved
yrlmanoharreddy
requested changes
Jul 21, 2025
Collaborator
yrlmanoharreddy
left a comment
There was a problem hiding this comment.
The class name and file name should match for consistency and to follow Java conventions. In your case, they are different—please update the file name or class name accordingly to resolve this. Check the old test cases class and make the modification similar. Thank you for your interest. And also make sure your branch is upto date with main.
Collaborator
|
If you're still open to continue working on this @DINES-04, I've taken over as the lead for the project and can help answer any questions you might have. |
Author
|
Sure sir |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActiveBuzzerHelperin the Test folderPwminterface to simulate hardwareactBuzzCheckflag, tone timing, and signal togglingLogCaptorto assert expected SLF4J logsTested
mvn testpasses locallyReviewer Notes
Please check:
InOrder)