Improve keyboard on notes screens ios android#262
Improve keyboard on notes screens ios android#262InfinityBowman wants to merge 13 commits intomainfrom
Conversation
…gle button not hiding any of the toolbar. This was such a pain.
lib/screens/EditNoteScreen.tsx
Outdated
| dispatch(toogleAddNoteState()); | ||
| } | ||
| }, 300); // allow WebView to flush | ||
| }, 300); // allow WebView to flush (note: react native doesnt use a webview - jacob) |
There was a problem hiding this comment.
react native does not however in some features ( video/image ) in expo it does use react-native-webview
There was a problem hiding this comment.
Oh, I see that tentap uses a webview internally for some things
yashcoded
left a comment
yashcoded
left a comment
There was a problem hiding this comment.
check this error out shows up whenever you run yarn start
Is this after you did any updating of expo? I had this same thing but I changed branches and did yarn install and then it works fine again |
after the package update yes try it out on your device i tried it on 2 devices still the error persists |
Yeah updating expo to 54 must have some breaking change for firebase. |
|
Well something with the testing library is broken now |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
using this pr to work on issue 263 |
4 participants
Lots of weird scroll behavior that I think I sorted out. The toolbar should be correctly placed above the keyboard with a close button on both IOS and Android on both the AddNoteScreen and EditNoteScreen. I also think that there could be something done in the future to combine parts of the AddNoteScreen and EditNoteScreen since they share a lot of common code. Try it out to make sure I didn't break anything.
Also added prettierrc and fixed a tsconfig error