Open
Conversation
Introduce maxBidsCount in MarsbaseBestBid and MarsbaseMarketplace Introduce maxMinimumOrderTokensLength in MarsbaseExchange Add new unit tests
Add maximumFee and check if the sum of feeAlice and feeBob <= maximumFee Add unit tests
Modify unit tests
…cancelOffer Add MarsBaseExchangeAttackMock to test reentrancy attacks Add receive function to MarsbaseExchange and MarsbaseBestBid to enable receiving ETH Add new and modify current unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closeExpiredOfferandcancelOfferinMarsbaseExchange. Add MarsBaseExchangeAttackMock and security test_nextOfferIdinsetNextOfferIdto ensure that thenextOfferIdwon't overwrite the current active offer.maximumFeeand perform safe-range validation forfeeAliceandfeeBob. Make SCALE a constant.receive() external payable {}to makeMarsbaseExchangeandMarsbaseBestBidbeing able to receive ETH0.8.19which is the latest version.solfiles:yarn prettier-sol,.jsfiles:yarn prettier-js