Skip to content

src/index: Add env var to hardcode current connections #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iakat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

src/index: Add env var to hardcode current connections #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ app.set('view engine', 'pug')
app.use(morgan('combined'))
app.use(express.static('offsets'))
let connectionCount = 0;
let publicConnectionCount = process.env.PUBLIC_CONNECTION_COUNT || connectionCount;
Copy link

@OiYouYeahYou OiYouYeahYou Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable will never change. In JS, with strings and numbers, you're not storing a reference, you're storing a value. If you wrapped this in an object that would work.

let address = process.env.ADDRESS;

app.get('/', (_, res) => {
res.render('index', { connectionCount, address });
res.render('index', { publicConnectionCount, address });
Copy link

@OiYouYeahYou OiYouYeahYou Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template views/index.pug depends on this value. So you're breaking that template.

});

app.get('/health', (req, res) => {
Expand Down Expand Up @@ -124,4 +125,4 @@ server.listen(port);
if (!address)
address = `http://${await publicIp.v4()}:${port}`;
logger.info('CrewLink Server started: %s', address);
})();
})();