AO3-7131 Text used by screen readers to announce help links is unclear

app/helpers/application_helper.rb

@@ -169,9 +169,10 @@ def text_byline(creation, options={})
   def link_to_modal(content = "", options = {})
     options[:class] ||= ""
     options[:for] ||= ""
-    options[:title] ||= options[:for]
 
     html_options = { class: "#{options[:class]} modal", title: options[:title] }
+    html_options[:"aria-label"] = options[:aria_label] if options[:aria_label]
+
     link_to content, options[:for], html_options
   end
 
@@ -183,12 +184,12 @@ def link_to_help(help_entry, link = '<span class="symbol question"><span>?</span
       help_file = "#{ArchiveConfig.HELP_DIRECTORY}/#{help_entry}.html"
     end
 
-    " ".html_safe + link_to_modal(link, for: help_file, title: help_entry.split('-').join(' ').capitalize, class: "help symbol question").html_safe
+    " ".html_safe + link_to_modal(link, for: help_file, aria_label: help_entry.split("-").join(" ").capitalize, class: "help symbol question").html_safe
   end
 
   def link_to_help_modal(help_path, title)
     link = tag.span(tag.span(t("application_helper.help_modal.help_symbol")), class: %w[symbol question])
-    " ".html_safe + link_to_modal(link, for: help_path, title: title, class: "help symbol question")
+    " ".html_safe + link_to_modal(link, for: help_path, aria_label: title, class: "help symbol question")
   end
 
   # Inserts the flash alert messages for flash[:key] wherever

config/locales/views/en.yml

@@ -2127,7 +2127,7 @@ en:
         legend: Display
         show_adult_content: Show me adult content without checking.
         show_whole_work_default: Show the whole work by default.
-      locale_help_title: Locale preferences
+      locale_help_title: Locale preferences help
       misc:
         heading: Misc
         legend: Misc

features/other_a/help.feature

@@ -9,7 +9,7 @@ Feature: Help
     Given I am logged in as "first_user"
     When I go to the collections page
     When I follow "New Collection"
-    And I follow "Collection moderated"
+    And I open help modal "Collection moderated"
     Then I should see "By default, collections are not moderated"
 
   Scenario: view the help popup for chapter title
@@ -29,7 +29,7 @@ Feature: Help
     And I fill in "content" with "Well, maybe not so epic."
     And I press "Post"
     And I follow "Add Chapter"
-    And I follow "Chapter title"
+    And I open help modal "Chapter title"
     Then I should see "You can add a chapter title"
 
   Scenario: Asked to log in if trying to access the first login page as guest

features/step_definitions/help_steps.rb

@@ -0,0 +1,4 @@
+When /^(?:|I )open help modal "([^"]*)"$/ do |link| # rubocop:disable Cucumber/RegexStepName
+  Capybara.enable_aria_label = true
+  step %{I follow "#{link}"}
+end

public/javascripts/ao3modal.js

@@ -197,7 +197,7 @@ jQuery(document).ready(function() {
                     .filter(function() {
                         return $(this).closest('.userstuff').length === 0;
                     }).click(function(event){
-                        _show($(this).attr('href'), $(this).attr('title'));
+                        _show($(this).attr('href'), $(this).attr('title') ? $(this).attr('title') : $(this).attr('aria-label'));
                         event.preventDefault();
                     });