Skip to content

Refactor GET search function with pagination and snippets #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeDontKnow3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor GET search function with pagination and snippets #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 69 additions & 50 deletions src/routes/api/search/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,54 +5,73 @@ import { articles } from '$lib/server/db/schema';
import { timeQuery } from '$lib/server/db/timing';

const MAX_QUERY_LENGTH = 200;
const MAX_RESULTS = 50;
const DEFAULT_RESULTS = 10;
const MIN_QUERY_LENGTH = 2;

export async function GET({ url }) {
const queryParam = url.searchParams.get('q')?.trim() || '';
const query = queryParam.slice(0, MAX_QUERY_LENGTH);
if (!query || query.length < 2) return json({ results: [] });

try {
const startTime = Date.now();

const rankingExpr = sql<number>`(
ts_rank_cd(${articles.search_vector}, websearch_to_tsquery('english', ${query}), 32) * 2 +
CASE WHEN ${articles.title} ILIKE ${query} THEN 2
WHEN ${articles.title} ILIKE ${query + '%'} THEN 1
ELSE 0
END -
(length(${articles.title}) * 0.001)
)`;

const results = await timeQuery('SEARCH_search_articles', () =>
db.select({
id: articles.id,
title: articles.title,
slug: articles.slug,
rank: rankingExpr,
})
.from(articles)
.where(sql`${articles.search_vector} @@ websearch_to_tsquery('english', ${query})`)
.orderBy(sql`${rankingExpr} DESC`)
.limit(50)
.execute()
);

console.log(`Search for "${query}" took ${Date.now() - startTime}ms`);

return json({
results: results.map(row => ({
id: row.id,
title: row.title.slice(0, 200),
slug: row.slug,
content: "View article about " + row.title.slice(0, 100) + "...",
relevance: row.rank
}))
});
} catch (error) {
console.error('Search error:', error);
return json({
results: [],
error: "Search temporarily unavailable"
}, { status: 500 });
}
}
function normalizeQuery(q: string) {
return q.replace(/[\u0000-\u001F\u007F]/g, '').replace(/\s+/g, ' ').trim();
}

export async function GET({ url }: any) {
const raw = url.searchParams.get('q') ?? '';
const pageParam = Number(url.searchParams.get('page') ?? '1');
const limitParam = Number(url.searchParams.get('limit') ?? String(DEFAULT_RESULTS));

const queryParam = normalizeQuery(raw).slice(0, MAX_QUERY_LENGTH);
if (!queryParam || queryParam.length < MIN_QUERY_LENGTH) return json({ results: [] });

const page = Number.isFinite(pageParam) && pageParam > 0 ? Math.floor(pageParam) : 1;
const limit = Number.isFinite(limitParam) && limitParam > 0 ? Math.min(Math.floor(limitParam), MAX_RESULTS) : DEFAULT_RESULTS;
const offset = (page - 1) * limit;

try {
const startTime = Date.now();

const rankingExpr = sql<number>`(
ts_rank_cd(${articles.search_vector}, websearch_to_tsquery('english', ${queryParam}), 32) * 2 +
CASE
WHEN lower(${articles.title}) = lower(${queryParam}) THEN 3
WHEN ${articles.title} ILIKE ${queryParam + '%'} THEN 1
ELSE 0
END - (length(${articles.title}) * 0.001)
)`;

const snippetExpr = sql<string>`ts_headline('english', ${articles.content}, websearch_to_tsquery('english', ${queryParam}), 'MaxFragments=2, MinWords=4, MaxWords=35, StartSel=<mark>, StopSel=</mark>')`;

const results = await timeQuery('SEARCH_search_articles', () =>
db.select({
id: articles.id,
title: articles.title,
slug: articles.slug,
rank: rankingExpr,
snippet: snippetExpr
})
.from(articles)
.where(sql`${articles.search_vector} @@ websearch_to_tsquery('english', ${queryParam})`)
.orderBy(sql`${rankingExpr} DESC`)
.limit(limit)
.offset(offset)
.execute()
);

console.log(`Search for "${queryParam}" took ${Date.now() - startTime}ms`);

return json({
results: results.map((row) => ({
id: row.id,
title: (row.title ?? '').slice(0, 200),
slug: row.slug,
content: (row.snippet ?? `View article about ${String(row.title ?? '').slice(0, 100)}...`).slice(0, 300),
relevance: Number(row.rank ?? 0)
})),
meta: { query: queryParam, page, limit }
});
} catch (error) {
console.error('Search error:', error);
return json({
results: [],
error: 'Search temporarily unavailable'
}, { status: 500 });
}
}