Always pass arguments from expression function #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if I was passing arguments to my resolvers with the expression function, I would get `null` instead of an instance if the query has no arguments (e.g. no parens at all in GQL). However, this breaks resolvers that require an instance argument. This makes `@arguments` always try to return an instance of an InputObject whenever it is required.
Contributor
|
|
Contributor
|
Hey @kix, I know a lot of time has passed, but would it be possible to provide an example, because I am not sure what you meant by the expression function, since you made a change in the @Vincz, could you also confirm that this is indeed a bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if I was passing arguments to my resolvers with the expression function, I would get
nullinstead of an instance if the query has no arguments (e.g. no parens at all in GQL).However, this breaks resolvers that require an instance argument. This makes
@argumentsalways try to return an instance of an InputObject whenever it is required.