Open
Conversation
JohnCorby
approved these changes
Dec 20, 2024
Member
JohnCorby
left a comment
JohnCorby
left a comment
There was a problem hiding this comment.
could mention that the 2gb is per-file but i dont think thats necessary
xen-42
approved these changes
Dec 21, 2024
Member
xen-42
left a comment
xen-42
left a comment
There was a problem hiding this comment.
Should probably document that the db tracks the first zip file in a release, to make it clear what an additional zip file is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the advent of larger mods in development, we'll eventually need to deal with mods that are too large for 2 GB release asset limit. After talking on the Discord our current idea is a new field in the manifest that tells the manager to download additional ZIP files by name from the release of the mod (simple enough to just get the parent of the
downloadUrlfrom the db and append the name to that). The manager would then extract these zip on top of the current mod's folder, effectively combining them all.