-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[TECHNICAL] Workflow to validate commit names #4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bb81ac to
decfb7b
Compare
decfb7b to
a933d8b
Compare
f1c57e4 to
b35cc56
Compare
joragua
requested changes
Jan 20, 2026
Collaborator
joragua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement @jesmrec! 💯 One comment about calens entry
1ada373 to
f805e4b
Compare
40afab2 to
4f643c0
Compare
joragua
approved these changes
Jan 21, 2026
Collaborator
joragua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌🏻
Collaborator
Author
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow to validate Conventional Commits through all the commits inside a PR.
Validation rules:
docs|fix|feat|chore|refactor|test|style|build|ci:If the commit name starts by
Mergeor[tx]will be ignored, as special casesEvery commit in the PR must match the rule, otherwise the check will not pass till it fits.
NOTE: scoped to the latest 100 commits. There is no way to know in advance (before the
checkout) how many commits conform the current PR. That means, if a PR contains more that 100 commits (very extreme), only the latest 100 will be checked out.Related Issues
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA