chore(web-app-admin-settings, web-app-files, design-system): [OCISDEV-391] ui-improvements #13319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mzner
force-pushed
the
chore/OCISDEV-391/ui-improvements
branch
from
451fbe2 to
d30a8e6
Compare
LukasHirt
reviewed
Nov 19, 2025
| class="oc-table-thead-content header-text" | ||
| v-text="extractFieldTitle(field)" | ||
| :aria-hidden="extractFieldTitle(field) ? 'false' : 'true'" | ||
| v-text="extractFieldTitle(field) || $pgettext('Table component header', 'icons')" |
Collaborator
There was a problem hiding this comment.
Feels a bit odd to have icons as the default. Can't we pass it to the component instead? When passing the fields...
mzner
force-pushed
the
chore/OCISDEV-391/ui-improvements
branch
from
d30a8e6 to
323f861
Compare
…-391] ui improvements
mzner
force-pushed
the
chore/OCISDEV-391/ui-improvements
branch
from
323f861 to
f4399d9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: