refactor(editor): flatten flags options
#15006
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
Sysix
force-pushed
the
10-27-refactor_editor_flatten_flags_options
branch
5 times, most recently
from
54f7014 to
d2122c0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the VSCode extension from using a generic flags object to dedicated, type-safe configuration properties for fixKind and disableNestedConfig. The deprecated flags configuration is maintained for backward compatibility.
Key changes:
- Introduced new
oxc.fixKindandoxc.disableNestedConfigconfiguration properties with proper typing - Deprecated the
oxc.flagsconfiguration object in favor of explicit properties - Updated all tests to use the new configuration API
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/package.json | Added new fixKind and disableNestedConfig configuration properties with enums and marked flags as deprecated |
| editors/vscode/client/WorkspaceConfig.ts | Implemented FixKind enum, added properties and methods for new config options with backward compatibility support |
| editors/vscode/tests/WorkspaceConfig.spec.ts | Updated tests to use new typed configuration properties instead of flags object |
| editors/vscode/tests/e2e_server.spec.ts | Updated test to use fixKind property instead of flags.fix_kind |
| editors/vscode/tests/code_actions.spec.ts | Updated test to use fixKind property instead of flags.fix_kind |
| editors/vscode/README.md | Updated documentation to document new fixKind and disableNestedConfig properties and marked flags section as deprecated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
10-27-refactor_editor_flatten_flags_options
branch
from
d2122c0 to
4f43808
Compare
Sysix
force-pushed
the
10-27-refactor_editor_flatten_flags_options
branch
from
4f43808 to
2ce3137
Compare
| strictEqual(config.configPath, null); | ||
| }); | ||
|
|
||
| test('configPath defaults to .oxlintrc.json when not using nested configs and configPath is empty', async () => { |
There was a problem hiding this comment.
These 2 test should be implementation details on the server.
They area already LintOptions::use_nested_config() tests, so we can safely delete them
Now the configuration
oxc.flagsis deprecated on the editor side too.It still sends the
flagsconfiguration to the language server, because it does not know which version is used. (defined withoxc.path.server).Updated all test + included a deprecated flag test.