Conversation
a5af38c to
238d250
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Maven publishing configuration by removing profile-based builds and moving plugins directly into the main build section. The change aims to adopt a supported publishing method, but introduces several issues that need to be addressed.
Key Changes:
- Removed
releaseandsonatypeMaven profiles - Moved javadoc, source, and GPG signing plugins from profiles to main build configuration
- Updated CI workflows to remove
-Preleaseflag from Maven commands
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pom.xml | Removed profile-based plugin configuration and moved javadoc, source, and GPG plugins to main build section |
| .github/workflows/push.yml | Removed -Prelease flag from deploy command |
| .github/workflows/pr.yml | Removed -Prelease flag from package command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
238d250 to
5139260
Compare
This switches to a supported method of publishing to the maven repository as the old method is no longer supported.
5139260 to
d950056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches to a supported method of publishing to the maven repository as the old method is no longer supported.