Skip to content

AB#81518 No longer log about null values.#185

Merged
buckett merged 1 commit intomasterfrom
AB#81518
Oct 19, 2025
Merged

AB#81518 No longer log about null values.#185
buckett merged 1 commit intomasterfrom
AB#81518

Conversation

@buckett
Copy link
Copy Markdown
Member

@buckett buckett commented Oct 16, 2025

The initial reason for adding this logging has passed (Instructure have deployed the change) and while it's slightly interesting that we still have some null values it's not worth chasing them down.

The initial reason for adding this logging has passed (Instructure have deployed the change) and while it's slightly interesting that we still have some `null` values it's not worth chasing them down.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Stop emitting logs for null values in LTI custom claims now that upstream has addressed the issue.

  • Removed the null-value logging check in JWTService.
  • Deleted the associated unit tests that only exercised the removed logging helper.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/java/uk/ac/ox/ctl/ltiauth/JWTService.java Removes checkForNullCustomValues and its invocation from createJWT to stop logging null custom claim values.
src/test/java/uk/ac/ox/ctl/ltiauth/JWTServiceTest.java Deletes tests that only validated the removed logging helper.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@buckett buckett merged commit cd21872 into master Oct 19, 2025
2 checks passed
@buckett buckett deleted the AB#81518 branch October 19, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants