Conversation
The initial reason for adding this logging has passed (Instructure have deployed the change) and while it's slightly interesting that we still have some `null` values it's not worth chasing them down.
There was a problem hiding this comment.
Pull Request Overview
Stop emitting logs for null values in LTI custom claims now that upstream has addressed the issue.
- Removed the null-value logging check in JWTService.
- Deleted the associated unit tests that only exercised the removed logging helper.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/uk/ac/ox/ctl/ltiauth/JWTService.java | Removes checkForNullCustomValues and its invocation from createJWT to stop logging null custom claim values. |
| src/test/java/uk/ac/ox/ctl/ltiauth/JWTServiceTest.java | Deletes tests that only validated the removed logging helper. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sebastianchristopher
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial reason for adding this logging has passed (Instructure have deployed the change) and while it's slightly interesting that we still have some
nullvalues it's not worth chasing them down.