Skip to content

AB#107916 Correctly handle incorrect client secret #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buckett merged 1 commit into from
Nov 25, 2025
Merged

AB#107916 Correctly handle incorrect client secret #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/uk/ac/ox/ctl/canvasproxy/OAuth2ErrorController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ public void handleError(
"Developer keys are mis-configured, check configuration.");
} else if ("unauthorized_client".equals(errorCode)) {
throw new OAuth2FlowException("This tool isn't enabled for your account.");
} else if ("invalid_client".equals(errorCode)) {
// If the client secret is wrong Canvas can return this error when attempting to retrieve the token.
throw new OAuth2FlowException("Check client ID and secret are correct.");
} else if (errorCode == null) {
// We have no errorCode at all and this is probably because the filter didn't run. This can happen if the
// user ends up re-visiting the URL returned from granting the access.
Expand Down