Skip to content

AB#114694 shrink the DB buffer size #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lardo-de-arnaud merged 1 commit into from
Mar 12, 2026
Merged

AB#114694 shrink the DB buffer size #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions aws/rds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ Resources:
log_output: "FILE"
long_query_time: "5"
slow_query_log: "1"
# 16MB. This is a reduction from the RDS default, which seems tuned for larger instances.
innodb_log_buffer_size: "16777216"
# 96MB. Shave a little off the default of 128MB to free some memory.
Comment on lines +155 to +157
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comments about the “RDS default” values look potentially inaccurate/misleading (e.g., innodb_log_buffer_size is 16MB here, which is commonly already the MySQL default, and innodb_buffer_pool_size defaults vary by engine/parameter group). Please confirm the actual defaults for the mysql${dbEngineMajorVer} family you deploy, and update the comments (or drop the override) so this doesn’t communicate the wrong baseline to future maintainers.

Suggested change
# 16MB. This is a reduction from the RDS default, which seems tuned for larger instances.
innodb_log_buffer_size: "16777216"
# 96MB. Shave a little off the default of 128MB to free some memory.
# Explicitly set to 16MB (16777216 bytes); adjust as needed for your workload/instance size.
innodb_log_buffer_size: "16777216"
# Explicitly set to ~96MB (100663296 bytes) to control InnoDB memory usage on smaller instances.

Copilot uses AI. Check for mistakes.
innodb_buffer_pool_size: "100663296"
Comment on lines +155 to +158
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

innodb_log_buffer_size and innodb_buffer_pool_size are now hard-coded to fixed byte values, so they won’t scale if dbInstanceSize changes (this template allows both db.t3.micro and db.t3.small). Consider making these values conditional/mapped per instance class (or per environment) so memory tuning remains appropriate when the instance size changes.

Copilot uses AI. Check for mistakes.

#dbOptionGroup:
# Type: "AWS::RDS::OptionGroup"
Expand Down
Loading