TQ: Implement network config replication #9317
Conversation
andrewjstone
force-pushed
the
tq-sprockets-3
branch
from
b19f5cf to
d1d409c
Compare
This code essentially re-implements the bootstore implementation of early network config replication over sprockets channels. The persistence of this state still lives in the bootstore, but will eventually move to the `trust-quorum` crate once all customer systems are running only trust quorum. This code does not deal with how the switchover from bootstore to to trust-quorum is made. That will come later with trust-quorum / sled-agent integration.
andrewjstone
force-pushed
the
tq-sprockets-4
branch
from
13880c8 to
36267b9
Compare
| info!( | ||
| self.log, | ||
| "Sending network config"; | ||
| "peer_id" => %h.baseboard_id, | ||
| "generation" => network_config.generation | ||
| ); | ||
| h.task_handle.send_network_config(network_config.clone()).await; | ||
| } |
There was a problem hiding this comment.
Can we call send_network_config instead of duplicating its contents here? Otherwise if we change one function we have to remember to change the other function too, and at some point we will forget.
There was a problem hiding this comment.
We take an efficiency hit doing things that way, because now we have to do a lookup for each peer_id that we already have a handle for. It's not that big a deal, but it feels somewhat wrong to take that hit. The primary deduplication is in the underlying call to task_handle.send_network_config, whereas here the duplication that exists is just a log message.
There was a problem hiding this comment.
I could pass a logger into the task_handle I suppose, and then log the message there. That would remove the duplication.
This builds on #9310
This code essentially re-implements the bootstore implementation of early network config replication over sprockets channels.
The persistence code of this state still lives in the bootstore, but will eventually move to the
trust-quorumcrate once all customer systems are running only trust quorum.This code does not deal with how the switchover from bootstore to to trust-quorum is made. That will come later with trust-quorum / sled-agent integration.