Open
Conversation
Not that we're ever building Propolis on a target where `usize` is not `u64`, but I'm going to follow this with a pass that adjusts conversions between u64 and usize and getting the types lined up is kinda helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not that we're ever building Propolis on a target where
usizeis notu64, but I'm going to follow this with a pass that adjusts conversions between u64 and usize and getting the types lined up is kinda helpful.this is the patch I mentioned here about moving some u64 to usize - I really just moved
ByteOffsetandByteLento u64 and followed the types a bit.there are a few different kinds of arguments around this:
usizeas file op sizes means if we did build Propolis for a 32-bit target a bunch of file stuff that was legal becomes broken (abstractly, there's nothing forbidding Propolis from building for say i686 even though we have absolutely no reason to)block/file.rs) will be 64-bit even if we build for 32-bit targets -libc::off_ton illumos is 8 bytes for some reasons I'd really rather not track down. this also applies for BlockIndex from Crucible.... it happens to line up disk bits and Oximeter reporting better, so that's nice. this doesn't actually change anything and this will go in after #1105. by then I'll have another change or two lined up after this that are more interesting.