Upgrade static.py so it is capable to add MODIFICATIONS into sync.json from a file#10
Upgrade static.py so it is capable to add MODIFICATIONS into sync.json from a file#10User-green wants to merge 6 commits intooxydien:1.21.1from
Conversation
Can now add MODIFICATIONS into sync.json
|
Hey, This looks good. I mean the feature is a very good idea and I'm on board with this, but I can already see some issues with the code... I noticed a potential issue with the JSON serialization that might cause problems with quote escaping. This could potentially lead to some unexpected behavior, so it might be worth taking a closer look at that part. Also, I see you're making edits through the browser interface. While that definitely works, you might find it easier to work locally - cloning the repo, switching to your - oxydien |
Can you expend on this? I think I understand what are you getring at, but I have no idea how to fix this. Well, exept may be validateing the whole thing after conversion.
Thanks. I have noticed the problem but wasnt realy thinking about it. I will most defenetly switch to local editing. Thought, I dont realy use IDE and am working in Kate. I will have to check if it supports git. |
Exactly what it says on the tin.
A bit hacky, review will is highly recommended.