Skip to content

Upgrade static.py so it is capable to add MODIFICATIONS into sync.json from a file#10

Open
User-green wants to merge 6 commits intooxydien:1.21.1from
User-green:patch-3
Open

Upgrade static.py so it is capable to add MODIFICATIONS into sync.json from a file#10
User-green wants to merge 6 commits intooxydien:1.21.1from
User-green:patch-3

Conversation

@User-green
Copy link

Exactly what it says on the tin.
A bit hacky, review will is highly recommended.

oxydien and others added 3 commits January 30, 2025 16:15
@User-green User-green changed the base branch from main to 1.21.1 June 23, 2025 10:01
@User-green User-green changed the base branch from 1.21.1 to main June 23, 2025 10:01
@oxydien
Copy link
Owner

oxydien commented Jun 23, 2025

Hey,

This looks good. I mean the feature is a very good idea and I'm on board with this, but I can already see some issues with the code... I noticed a potential issue with the JSON serialization that might cause problems with quote escaping. This could potentially lead to some unexpected behavior, so it might be worth taking a closer look at that part.

Also, I see you're making edits through the browser interface. While that definitely works, you might find it easier to work locally - cloning the repo, switching to your User-green:patch-3 branch, and using a code editor like VSCodium or IntelliJ. It can make debugging and testing much smoother, plus there are lots of helpful tutorials out there if you're interested in trying that workflow.

- oxydien

@User-green
Copy link
Author

User-green commented Jun 23, 2025

Hey,

This looks good. I mean the feature is a very good idea and I'm on board with this, but I can already see some issues with the code... I noticed a potential issue with the JSON serialization that might cause problems with quote escaping. This could potentially lead to some unexpected behavior, so it might be worth taking a closer look at that part.

Can you expend on this? I think I understand what are you getring at, but I have no idea how to fix this. Well, exept may be validateing the whole thing after conversion.

Also, I see you're making edits through the browser interface. While that definitely works, you might find it easier to work locally - cloning the repo, switching to your User-green:patch-3 branch, and using a code editor like VSCodium or IntelliJ. It can make debugging and testing much smoother, plus there are lots of helpful tutorials out there if you're interested in trying that workflow.

Thanks. I have noticed the problem but wasnt realy thinking about it. I will most defenetly switch to local editing. Thought, I dont realy use IDE and am working in Kate. I will have to check if it supports git.
Thanks again.

@User-green User-green changed the base branch from main to downgrade/1.20.1 June 23, 2025 21:33
@User-green User-green changed the base branch from downgrade/1.20.1 to 1.21.1 June 23, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments