Skip to content

chore: dtype handling in args#241

Open
avocadoali wants to merge 2 commits intomainfrom
chore/args-dtype-handling
Open

chore: dtype handling in args#241
avocadoali wants to merge 2 commits intomainfrom
chore/args-dtype-handling

Conversation

@avocadoali
Copy link

No description provided.

@avocadoali avocadoali requested a review from Copilot October 28, 2025 18:03
cursor[bot]

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves type safety and configuration handling for dtype parameters by converting string-based dtype specifications to use Literal types and a mapping dictionary. The changes ensure that dtype arguments are properly validated at the CLI level and converted to JAX dtype objects before being passed to the main training functions.

Key Changes:

  • Added Literal type hints for lr_schedule, param_dtype, and dtype fields to restrict valid values
  • Introduced DTYPE_MAP dictionary to convert string dtype specifications to JAX dtype objects
  • Added dtype information to wandb logging configuration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
jasmine/train_tokenizer.py Added dtype type safety with Literal hints, dtype mapping, and conditional flash attention disabling
jasmine/train_lam.py Applied same dtype handling improvements as train_tokenizer.py
jasmine/train_dynamics.py Applied same dtype handling improvements as train_tokenizer.py

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avocadoali avocadoali requested a review from Copilot October 28, 2025 18:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant