Propagate Electron ID score to GT object#154
Open
gpetruc wants to merge 1 commit intop2l1pfp:L1PF_15_1_Xfrom
Open
Propagate Electron ID score to GT object#154gpetruc wants to merge 1 commit intop2l1pfp:L1PF_15_1_Xfrom
gpetruc wants to merge 1 commit intop2l1pfp:L1PF_15_1_Xfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the GT electron hardware data model to carry an electron ID score (stored as an ap_ufixed<8,1> probability-like quantity) and propagates the score from the L1CT electron object into the GT electron object during conversion.
Changes:
- Add
idScorefield tol1gt::Electronand include it in pack/unpack bit-serialization. - Add
CTtoGT_idProbahelper to convertl1ct::id_score_t(≈[-1, 1)) intol1gt::id_proba_t(intended [0,1]). - Populate
l1gt::Electron::idScoreinEGIsoEleObj::toGT().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
DataFormats/L1TParticleFlow/interface/gt_datatypes.h |
Adds idScore to GT electron bit-format and introduces CT→GT ID-score conversion helper. |
DataFormats/L1TParticleFlow/interface/egamma.h |
Wires L1CT electron ID score into the GT electron object during toGT() conversion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… tagging (ap_ufixed<8,1>), range [0, 1]
gpetruc
force-pushed
the
eleId_to_GT_15X
branch
from
6a0d297 to
50ed122
Compare
Collaborator
Author
|
Correlator-common merge request: https://gitlab.cern.ch/cms-cactus/phase2/firmware/correlator-common/-/merge_requests/216 |
gpetruc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate Electron ID score to GT object, object using the same format as jet tagging (
ap_ufixed<8,1>), range [0.0, 1.0] with LSB=1/128