Update MAC CI #164
Draft
Update MAC CI #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pickup the existing tokio runtime if the node is created inside an existing runtime. This is handy for tests or applications that use tokio already.
Now that the node pickes up an already existing runtime, we can use tokio::test macro.
This should fix many of the networking issues we incountered.
Ideally p2panda would reexport it but we will need it to turn on online collaboration.
This enables online collaboration.
We can reset the migrations since we are changing the CNN, so old databases will be inaccessible for us any way.
Use the same naming convetion as p2panda. And also also reduce the confusion with reflection-doc.
jsparber
force-pushed
the
jsparber/mac_ci
branch
4 times, most recently
from
01c93d8 to
768f6a0
Compare
jsparber
force-pushed
the
jsparber/mac_ci
branch
from
768f6a0 to
efc1170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cafca I took your merge request and rebased in. I'm playing with building on Mac with a friend right now.