use ClientPool to prevent race conditions when using pylibmc as memcached package#287
Open
drcpu-github wants to merge 2 commits intopallets-eco:mainfrom
Open
use ClientPool to prevent race conditions when using pylibmc as memcached package#287drcpu-github wants to merge 2 commits intopallets-eco:mainfrom
drcpu-github wants to merge 2 commits intopallets-eco:mainfrom
Conversation
3b51f50 to
2322e34
Compare
8141bfb to
96103b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch aims to fix concurrency issues when using the
gthreadworker class in gunicorn in combination with thepylibmcMemcached backend by utilizing aClientPoolrather than a singleClient. This issue was also (partially) detailed in pallets-eco/flask-caching#113.The proposed solution should work for every gunicorn worker configuration, so this patch always uses a
ClientPoolin an attempt to not further complicate the code with unnecessary branching statements. If you prefer it otherwise, I can still change that using a configuration switch.Note that this patch also requires some changes to the
flask-cachingrepository, but I first want to iterate on it here before opening another PR in that repository.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.