This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Fix incorrect id resolution#68
Open
jasonchoimtt wants to merge 2 commits intopallets-eco:masterfrom
jasonchoimtt:master
Open
Fix incorrect id resolution#68jasonchoimtt wants to merge 2 commits intopallets-eco:masterfrom jasonchoimtt:master
jasonchoimtt wants to merge 2 commits intopallets-eco:masterfrom
jasonchoimtt:master
Conversation
|
This is addressed in #63 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code does not correctly resolve the id from the intended order: attribute -> key, but instead will raise an AttributeError if there is no such attribute. It will also not accept a falsy .id attribute, e.g. 0. This patch fixes the issue.