Make uv run --all-extras pyright --verifytypes click pass

[adamtheturtle]

I am not familiar with the CI setup of this project, so if there is a wish to have this in CI, I'd like to be instructed, or leave that to someone else please.

fixes #3067

[davidism]

Please rebase and retarget to stable.

[davidism]

click/pyproject.toml

Lines 171 to 176 in 81a482f

	[tool.tox.env.typing]
	description = "run static type checkers"
	dependency_groups = ["typing"]
	commands = [
	["mypy"],
	]

This is the tox job that runs type checks. Add the verifytypes call as another item in the list.

[adamtheturtle]

Thank you @davidism , I have made the changes you requested

[davidism]

Need --ignoreexternal here as well.

[adamtheturtle]

Why? Given that this is passing as-is

[davidism]

Consistency with the other projects. Click doesn't have any dependencies (except stdlib modules), but if it did for some reason (like Flask) verifytypes tends to fail unhelpfully.

[adamtheturtle]

Thank you. I have made this change.

I personally like to avoid --ignoreexternal so that I know the interfaces I ship are type safe, even if that means choosing to avoid some dependencies.

[davidism]

For example, Flask-SQLAlchemy-Lite fails without ignoreexternal, even though SQLAlchemy goes to amazing lengths to work with typing.

[adamtheturtle]

Thank you for the context. The latest commit addresses this so I'm hoping that it can be merged.

[adamtheturtle]

@davidism I have addressed all the inline comments and I am hoping for this to be merged.