TST: Every function ensure_clean in the file /pandas/tests/io/test_common.py and /pandas/tests/io/pytables/test_store.py has been replaced. #62895
+94
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmon.py and /pandas/tests/io/pytables/test_store.py has been replaced.
|
Assists #62435 |
mroeschke
reviewed
Oct 29, 2025
pandas/tests/io/test_common.py
Outdated
| with tm.ensure_clean() as path: | ||
| file = Path(path) | ||
| file.write_bytes(content) | ||
| file = Path(temp_file) |
There was a problem hiding this comment.
temp_file should already be a Path
There was a problem hiding this comment.
Thank you for your correction, I have never used pytest fixtures before, so I make this mistake,I will fix it today and update this PR.
mroeschke
approved these changes
Oct 30, 2025
mroeschke
added
the
Testing
|
Thanks @zhangbowen-coder |
|
Thank you for your review and correction, too. @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every function ensure_clean in the file /pandas/tests/io/test_common.py
and /pandas/tests/io/pytables/test_store.py has been replaced.
Assists #62435