Skip to content

Conversation

@micol-altomare
Copy link

@micol-altomare micol-altomare commented Nov 26, 2025

Replace ensure_clean_store with tmp_path fixture in the following files:

  • pandas/tests/io/pytables/test_keys.py
  • pandas/tests/io/pytables/test_complex.py
  • pandas/tests/io/pytables/test_file_handling.py

Specifically,

  • Replace all occurrences of ensure_clean_store with + HDFStore(tmp_path / setup_path)
  • Removed ensure_clean_store imports (no longer used)
  • Added tmp_path parameter to modified test functions

=====

  • Code fixes #xxx
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

@micol-altomare micol-altomare force-pushed the micol-altomare-replace-ensure-clean-store branch from f981616 to 1b5b02c Compare November 27, 2025 17:00
@micol-altomare micol-altomare marked this pull request as draft November 29, 2025 18:25
@micol-altomare micol-altomare marked this pull request as ready for review November 29, 2025 18:25
@micol-altomare micol-altomare changed the title TST: Replace ensure_clean_store with tmp_path in test_keys.py, test_complex.py, test_file_handling.py TST: Replace ensure_clean_store with tmp_path in test_complex.py, test_file_handling.py Nov 29, 2025
@micol-altomare
Copy link
Author

Hi @mroeschke! 👋 Would you mind reviewing this PR (for #62435) and letting me know if there are any changes needed on my end in order to successfully merge? Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant