Update form_helper syntax for Rails 4 compatibility.#4
Open
bdcheung wants to merge 12 commits intopaneq:masterfrom
Open
Update form_helper syntax for Rails 4 compatibility.#4bdcheung wants to merge 12 commits intopaneq:masterfrom
bdcheung wants to merge 12 commits intopaneq:masterfrom
Conversation
…an now be easily overriden for I18n
Merging Brian's changes into ASEE fork
Ruby 1.9 and greater changed the manner in which slashed numerical dates are parsed. 1.8.7 parsed slashed dates as mm/dd/yyyy, 1.9.1+ parses them as dd/mm/yyyy. As a result, users who bypass the calendar_date_select helper modal and manually enter dates into the form input with American format (mm/dd/yyyy) could result in incorrect data being written to the database or an ArgumentError: argument out of range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionView::Helpers::InstanceTag is removed in Rails 4. This pull request fixes the form helpers to use the ActionView::Helpers::Tags::TextField methods to generate the HTML tags for the data select.