Make a SiteDetails dataclass when creating a location#1169
Merged
wtgee merged 3 commits intopanoptes:developfrom Aug 19, 2022
Merged
Make a SiteDetails dataclass when creating a location#1169wtgee merged 3 commits intopanoptes:developfrom
SiteDetails dataclass when creating a location#1169wtgee merged 3 commits intopanoptes:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1169 +/- ##
===========================================
- Coverage 83.08% 74.37% -8.71%
===========================================
Files 86 90 +4
Lines 7425 7708 +283
Branches 635 855 +220
===========================================
- Hits 6169 5733 -436
- Misses 1083 1835 +752
+ Partials 173 140 -33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wtgee
added a commit
that referenced
this pull request
Apr 9, 2025
* Make a `SiteDetails` dataclass when creating a location. * Missed test * * More dataclass fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier to work with SiteDetails. This will be a coming feature of some of the task-based work as well and assists with those coming changes.
Pulled from #1167