Skip to content

Update state machine#1378

Open
wtgee wants to merge 3 commits intodevelopfrom
cleanup-state-machine-1375
Open

Update state machine#1378
wtgee wants to merge 3 commits intodevelopfrom
cleanup-state-machine-1375

Conversation

@wtgee
Copy link
Member

@wtgee wtgee commented Sep 19, 2025

  • Adds a simple state file that removes the pointing, tracking, and analyzing states, which were effectively being skipped via options.
  • Defaults to new state machine.

⚠️ Needs to be tested on hardware for a full night before merging ⚠️

simple.yaml (new state machine):
Screenshot 2025-09-19 at 09 17 12

panoptes.yaml (old state machine):
Screenshot 2025-09-19 at 09 17 05

Closes #1375

@wtgee wtgee requested a review from Copilot September 19, 2025 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the state machine by removing intermediate states (pointing, tracking, and analyzing) and defaulting to a streamlined workflow. The changes create a more direct path from slewing to observing to scheduling, reducing complexity in the observatory control system.

  • Creates a new simplified state machine configuration that eliminates redundant intermediate states
  • Updates state transitions to skip the removed states and go directly between core operational states
  • Changes the default state machine from panoptes to simple

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/panoptes/pocs/state/states/default/slewing.py Updates transition from slewing to go directly to observing instead of pointing
src/panoptes/pocs/state/states/default/scheduling.py Changes existing observation handling to go to slewing instead of tracking
src/panoptes/pocs/state/states/default/observing.py Modifies completion transition to go to scheduling instead of analyzing
conf_files/state_table/simple.yaml Adds new simplified state machine configuration without intermediate states
conf_files/pocs.yaml Changes default state machine from panoptes to simple

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.76%. Comparing base (62caa62) to head (843843e).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/panoptes/pocs/state/states/default/observing.py 0.00% 2 Missing ⚠️
src/panoptes/pocs/state/states/default/slewing.py 0.00% 2 Missing ⚠️
src/panoptes/pocs/observatory.py 88.88% 1 Missing ⚠️
...c/panoptes/pocs/state/states/default/scheduling.py 0.00% 1 Missing ⚠️
tests/scheduler/test_dispatch_scheduler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1378      +/-   ##
===========================================
+ Coverage    64.46%   64.76%   +0.29%     
===========================================
  Files          103       99       -4     
  Lines         9368     9084     -284     
  Branches       831      801      -30     
===========================================
- Hits          6039     5883     -156     
+ Misses        3188     3057     -131     
- Partials       141      144       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wtgee wtgee self-assigned this Sep 19, 2025
@wtgee wtgee force-pushed the cleanup-state-machine-1375 branch from e41b444 to 2ccffba Compare September 20, 2025 16:40
@wtgee wtgee force-pushed the cleanup-state-machine-1375 branch from 58dd020 to 5407204 Compare February 6, 2026 00:55
@wtgee wtgee requested a review from Copilot February 6, 2026 02:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Adds a `simple` state file that removes the `pointing`, `tracking`, and `analyzing` states, which were effectively being skipped via options.
* Defaults to new state machine.

:warning: Needs to be tested on hardware for a full night before merging :warning:
* Remove unused `Image` class.
* Remove related tests.
@wtgee wtgee force-pushed the cleanup-state-machine-1375 branch from 843843e to 01f64a4 Compare February 18, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up state machine

2 participants