Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the state machine by removing intermediate states (pointing, tracking, and analyzing) and defaulting to a streamlined workflow. The changes create a more direct path from slewing to observing to scheduling, reducing complexity in the observatory control system.
- Creates a new simplified state machine configuration that eliminates redundant intermediate states
- Updates state transitions to skip the removed states and go directly between core operational states
- Changes the default state machine from
panoptestosimple
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/panoptes/pocs/state/states/default/slewing.py | Updates transition from slewing to go directly to observing instead of pointing |
| src/panoptes/pocs/state/states/default/scheduling.py | Changes existing observation handling to go to slewing instead of tracking |
| src/panoptes/pocs/state/states/default/observing.py | Modifies completion transition to go to scheduling instead of analyzing |
| conf_files/state_table/simple.yaml | Adds new simplified state machine configuration without intermediate states |
| conf_files/pocs.yaml | Changes default state machine from panoptes to simple |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1378 +/- ##
===========================================
+ Coverage 64.46% 64.76% +0.29%
===========================================
Files 103 99 -4
Lines 9368 9084 -284
Branches 831 801 -30
===========================================
- Hits 6039 5883 -156
+ Misses 3188 3057 -131
- Partials 141 144 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e41b444 to
2ccffba
Compare
58dd020 to
5407204
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Adds a `simple` state file that removes the `pointing`, `tracking`, and `analyzing` states, which were effectively being skipped via options. * Defaults to new state machine. :warning: Needs to be tested on hardware for a full night before merging :warning:
* Remove unused `Image` class. * Remove related tests.
843843e to
01f64a4
Compare
simplestate file that removes thepointing,tracking, andanalyzingstates, which were effectively being skipped via options.simple.yaml(new state machine):panoptes.yaml(old state machine):Closes #1375