Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project's build and configuration infrastructure by migrating from setuptools to hatchling, consolidating settings, and updating documentation.
Key changes:
- Migrated build configuration from
setup.py/setup.cfgtopyproject.tomlusing hatchling - Consolidated enums (
ImageStatus,ObservationStatus) intosettings.pyand removedImagePathInfoclass - Updated documentation build process and added comprehensive build instructions
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Replaced setuptools configuration with hatchling build backend and consolidated all project metadata |
| setup.py | Removed legacy setuptools entry point |
| setup.cfg | Removed legacy configuration file |
| tox.ini | Removed tox configuration |
| environment.yaml | Removed conda environment file |
| .isort.cfg | Removed isort configuration (likely moved to pyproject.toml or replaced by ruff) |
| src/panoptes/data/settings.py | Added ImageStatus and ObservationStatus enums, removed PATH_MATCHER regex |
| src/panoptes/data/images.py | Removed entire file containing ImagePathInfo and ImageStatus classes |
| src/panoptes/data/observations.py | Removed ObservationStatus enum (moved to settings.py) and reordered imports |
| src/panoptes/data/search.py | Reordered imports, removed unused astropy import, simplified f-string formatting |
| src/panoptes/data/utils/cli/main.py | Updated type hints to use modern Python 3.12 syntax, removed unused exception variable |
| tests/conftest.py | Removed placeholder test configuration file |
| tests/test_skeleton.py | Removed skeleton test file |
| docs/conf.py | Updated copyright year, reordered imports, added autodoc_mock_imports, modernized f-string |
| docs/index.md | Added user documentation table of contents |
| docs/readme.md | Added comprehensive documentation build instructions |
| docs/requirements-full.txt | Added full documentation requirements file |
| .readthedocs.yaml | Updated to use requirements-full.txt for documentation builds |
| .github/workflows/docs.yml | Added new GitHub Actions workflow for building and deploying documentation |
| README.md | Reformatted code examples from doctest style to plain Python |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Move build settings over to `pyproject.toml`. * Remove unused files.
…ls`. * ruff & lint
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.toml.ImagePathInfo(there is one inpanoptes-utils.ImageStatusandObservationStatusenums into the settings file.Closes #8