Skip to content

Fix Dockerfile#49

Open
ndahlquist wants to merge 3 commits intopanrafal:masterfrom
LeiaInc:master
Open

Fix Dockerfile#49
ndahlquist wants to merge 3 commits intopanrafal:masterfrom
LeiaInc:master

Conversation

@ndahlquist
Copy link

These are the code changes we needed to make in order to get the app to work correctly from the Dockerfile. Unfortunately I had to move the directory structure, so feel free to close this if you think it is not a good change

@mridulgain
Copy link

Instead of ubuntu why not use node as base image?

@ndahlquist
Copy link
Author

Not sure; we didn't spend too much time optimizing, just wanted to fix the functionality.

For what it's worth, the old Dockerfile also appears to use ubuntu as the base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments