fix(engine): defer backfill action while persistence is active#23271
Open
ArshLabs wants to merge 1 commit intoparadigmxyz:mainfrom
Open
fix(engine): defer backfill action while persistence is active#23271ArshLabs wants to merge 1 commit intoparadigmxyz:mainfrom
ArshLabs wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change prevents backfill escalation signals from being dropped while persistence is active.
When a disconnected downloaded block triggers a backfill action during persistence, the action is now deferred and emitted as soon as persistence completes and backfill is idle.
Root Cause
Tree events can request backfill from disconnected downloaded blocks.
That request is forwarded to event emission, but the backfill event path previously returned early if persistence was in progress, which dropped the signal at that moment.
Changes
Why this is safe
Backfill and persistence are already mutually exclusive. The new behavior keeps that contract and only changes handling from drop to deferred handoff.
Testing