WIP bump alloy-evm to af60ab3, remove gas output from execute_transaction#23327
Draft
WIP bump alloy-evm to af60ab3, remove gas output from execute_transaction#23327
Conversation
alloy-evm's BlockExecutor::execute_transaction_with_commit_condition and commit_transaction no longer return gas used. Gas tracking is now fully internal to the executor. Callers that need per-transaction gas compute it from receipt cumulative_gas_used differences.
Contributor
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alloy-evm's BlockExecutor::execute_transaction_with_commit_condition and commit_transaction no longer return gas used. Gas tracking is now fully internal to the executor. Callers that need per-transaction gas compute it from receipt cumulative_gas_used differences.
Testing how it would look