Skip to content

WIP bump alloy-evm to af60ab3, remove gas output from execute_transaction#23327

Draft
rakita wants to merge 1 commit intotip1016from
tip1016-rm-gas-output
Draft

WIP bump alloy-evm to af60ab3, remove gas output from execute_transaction#23327
rakita wants to merge 1 commit intotip1016from
tip1016-rm-gas-output

Conversation

@rakita
Copy link
Copy Markdown
Collaborator

@rakita rakita commented Apr 1, 2026

alloy-evm's BlockExecutor::execute_transaction_with_commit_condition and commit_transaction no longer return gas used. Gas tracking is now fully internal to the executor. Callers that need per-transaction gas compute it from receipt cumulative_gas_used differences.

Testing how it would look

alloy-evm's BlockExecutor::execute_transaction_with_commit_condition and
commit_transaction no longer return gas used. Gas tracking is now fully
internal to the executor. Callers that need per-transaction gas compute
it from receipt cumulative_gas_used differences.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

  • feat: add new user login
  • fix: correct button size
  • docs: update README

Usage:

  • feat: Introduces a new feature
  • fix: Patches a bug
  • chore: General maintenance tasks or updates
  • test: Adding new tests or modifying existing tests
  • bench: Adding new benchmarks or modifying existing benchmarks
  • perf: Performance improvements
  • refactor: Changes to improve code structure
  • docs: Documentation updates
  • ci: Changes to CI/CD configurations
  • revert: Reverts a previously merged PR
  • deps: Updates dependencies

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

  • feat!: changed the API
  • chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

⚠️ Changelog not found.

A changelog entry is required before merging. We've generated a suggested changelog based on your changes:

Preview
---
reth-evm: minor
reth-engine-util: patch
reth-ethereum-payload-builder: patch
reth-rpc-eth-api: patch
reth-rpc: patch
example-custom-beacon-withdrawals: patch
---

Bumped `alloy-evm` to `af60ab3` and removed gas output from `execute_transaction`, which now returns `Result<(), BlockExecutionError>` instead of `Result<u64, BlockExecutionError>`. Callers now read cumulative gas used from the last receipt via `builder.executor().receipts()` instead of using the return value.

Add changelog to commit this to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant