Skip to content

Conversation

@mcr
Copy link

@mcr mcr commented Dec 13, 2025

This replaces PR #578.
It is rebased after ther DOCS_RS changes.
Without this patch, the version number does not parse with VersionReq::parse.

(This depends upon #603, please merge that first)

@mcr mcr force-pushed the sanitize-tss-version-number-too branch from 9ae4929 to bdd2e39 Compare December 13, 2025 00:44
@Superhepper
Copy link
Collaborator

I am not against this. But I would like for the sanitize of the TSS version to be opt-in by using environment variable or by some other means.

@mcr
Copy link
Author

mcr commented Dec 13, 2025

I am not against this. But I would like for the sanitize of the TSS version to be opt-in by using environment variable or by some other means.

okay, that sounds okay to me.
Please name the environment variable for me... :-)
I think that I also build tss statically, and I believe I had to patch it to make it all work without .so.
(when debugging, the wrong .so always winds up loading when you least expect it. That's neither here nor there, but I'm thinking about the documentation update on the environment variable)

@mcr mcr marked this pull request as draft December 13, 2025 15:55
@Superhepper
Copy link
Collaborator

Every other environment variable that has to deal with tpm2-tss is named something with TPM2_TSS_*. So something like TPM2_TSS_VERSION_ALLOW_DIRTY
TPM2_TSS_VERSION_DIRTY
TPM2_TSS_VERSION_ALLOW_PRE_VERSION
TPM2_TSS_IS_PRE_VERSION

Interesting I tried to build it with static linkage when I finished bundled. But it a bit more complicated so I left it for the future. But if it would be possible to have static linkage on all platforms I think that would be great.

@mcr
Copy link
Author

mcr commented Dec 14, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants