Open
Conversation
Collaborator
|
I am not a go expert, but you could make the counter thread safe, right? import "sync/atomic"
type Counter struct {
value int64
}
func NewCounter(initialCount int64) *Counter {
return &Counter{
value: initialCount,
}
}
func (c *Counter) Increment() int64 {
return atomic.AddInt64(&c.value, 1)
} |
Author
|
@ericelliott great suggestion, thanks! made the updates in: nrednav/cuid2#1 and nrednav/cuid2#2 |
Author
|
Package updated to include latest changes: nrednav/cuid2#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to port: nrednav/cuid2
Apologies for yet another Go port of this library. I noticed the other implementations did not include a complete suite of tests and so I wanted to try my hand at recreating the full package, including collision tests.
I tried to incorporate as much as I could gather from the ongoing discussion in #33. Would greatly appreciate any feedback.
Todo / Missing
buildHistogram