Warnings in the build process / treat as errors#155
Closed
tcptomato wants to merge 1 commit intoparallella:masterfrom
Closed
Warnings in the build process / treat as errors#155tcptomato wants to merge 1 commit intoparallella:masterfrom
tcptomato wants to merge 1 commit intoparallella:masterfrom
Conversation
Contributor
|
Why do not merge? I think it should be to enforce the no-warning policy. |
Author
|
Because as is, it will break the build process. ( This is why Travis says the build for this commit failed :) ) |
Member
|
Pushed compiler warning fixes. Can you rebase on master so we can see if it passes on travis too? Thanks, |
Author
|
I rebased it on master. Which is 3 commits behind upstream/master. But when I add as a remote to get the changes, I get a permission denied on the git fetch. Gtg now, will debug later. |
Author
|
Added latest changes from upstream. See pull request #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People are starting to commit code for which the compiler gives warnings. This can be dangerous as it might hide bugs, and could break the code in the future. The solution to this problem is the -Werror compiler flag, which treats warnings as errors.
This pull request shouldn't be merged atm, as it will break the build process. I created it more to start a discussion on this topic.
Changes.
Modified readme and the travis configuration file as to treat warnings as errors.