Merged
Conversation
Undoing hack suffix hack from #12 The [underlying subname issue](paritytech/dotns#51) has been fixed (https://github.com/paritytech/dotns/pull/48/changes#diff-0f6b3347001b943959ded58452c49f4e78409d76265b8289261aa6636044edd7R138).
CI Summary
Deploy Example — Passed
Labelstype: docs |
Collaborator
Author
|
For a cleaner change, we should merge https://github.com/paritytech/mark3t/pull/174 first |
Member
|
@andrew-ifrita what about the sdk changes in the cli i recall seeing changes there too? |
Collaborator
Author
Those were unrelated to the hack. It was an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undoing hack suffix hack from #12 The underlying subname issue has been fixed (https://github.com/paritytech/dotns/pull/48/changes#diff-0f6b3347001b943959ded58452c49f4e78409d76265b8289261aa6636044edd7R138).
Description
Type
Package
@dotns/cliRelated Issues
Fixes
Checklist
Documentation
Breaking Changes
Breaking changes:
subname suffix is no longer used in the workflow. Only impacts
mark3twith the relevant PR in place at https://github.com/paritytech/mark3t/pull/174Testing
How to test:
Notes