Skip to content

chore: Undo subname deployment hack#17

Merged
andrew-ifrita merged 1 commit intomainfrom
chore/undo-subname-deployment-hack
Mar 3, 2026
Merged

chore: Undo subname deployment hack#17
andrew-ifrita merged 1 commit intomainfrom
chore/undo-subname-deployment-hack

Conversation

@andrew-ifrita
Copy link
Collaborator

Undoing hack suffix hack from #12 The underlying subname issue has been fixed (https://github.com/paritytech/dotns/pull/48/changes#diff-0f6b3347001b943959ded58452c49f4e78409d76265b8289261aa6636044edd7R138).

Description

Type

  • Bug fix
  • Feature
  • Breaking change
  • Documentation
  • Chore

Package

  • @dotns/cli
  • Root/monorepo
  • Documentation

Related Issues

Fixes

Checklist

Documentation

  • README updated if needed
  • Types updated if needed

Breaking Changes

  • No breaking changes
  • Breaking changes documented below

Breaking changes:

subname suffix is no longer used in the workflow. Only impacts mark3t with the relevant PR in place at https://github.com/paritytech/mark3t/pull/174

Testing

How to test:

Notes

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

CI Summary

Check Result
Lint Passed
Format Passed
Typecheck Passed
Build Passed
Deploy Example Passed
PR Title Passed
Labels Passed

Deploy Example — Passed
Stage Status
✓ Site validation Site validated
✓ Deploy Deployed
Property Value
Domain pr17.dotns-example-site.dot
CID bafybeiflogugoparbfxhj7ysibqhw7zpswg4hm6gstkzydnkitf3b3zi6a
URL https://pr17.dotns-example-site.paseo.li

View run

Labels

type: docs

@andrew-ifrita
Copy link
Collaborator Author

For a cleaner change, we should merge https://github.com/paritytech/mark3t/pull/174 first

Copy link
Member

@sphamjoli sphamjoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sphamjoli
Copy link
Member

@andrew-ifrita what about the sdk changes in the cli i recall seeing changes there too?

@andrew-ifrita
Copy link
Collaborator Author

@andrew-ifrita what about the sdk changes in the cli i recall seeing changes there too?

Those were unrelated to the hack. It was an address feature to print the address of the given key/mnemonic, and then it was converting some output to stderr so it was easier to capture stdout

@andrew-ifrita andrew-ifrita merged commit 418f4a6 into main Mar 3, 2026
10 checks passed
@andrew-ifrita andrew-ifrita deleted the chore/undo-subname-deployment-hack branch March 3, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants