Skip to content

fix(rest): Prevent default ACL from overwriting custom ACL on update #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
walhalabi-code wants to merge 2 commits into
base: alpha
Choose a base branch
from
Open

fix(rest): Prevent default ACL from overwriting custom ACL on update #10003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb620f2
fix: Apply default ACL only on object creation, not update
walhalabi-code Jan 4, 2026
5c830dc
test: Add tests for default ACL behavior on update
walhalabi-code Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions spec/ParseACL.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,4 +951,65 @@ describe('Parse.ACL', () => {
expect(acl[user.id].write).toBeTrue();
expect(acl[user.id].read).toBeTrue();
});

it('should not overwrite ACL with defaultACL on update', async () => {
await new Parse.Object('TestObject').save();
const schema = await Parse.Server.database.loadSchema();
await schema.updateClass(
'TestObject',
{},
{
create: { '*': true },
update: { '*': true },
ACL: {
'*': { read: true },
currentUser: { read: true, write: true },
},
}
);
const user = await Parse.User.signUp('testuser', 'p@ssword');
const obj = new Parse.Object('TestObject');
await obj.save(null, { sessionToken: user.getSessionToken() });

const originalAcl = obj.getACL().toJSON();
expect(originalAcl['*']).toEqual({ read: true });
expect(originalAcl[user.id]).toEqual({ read: true, write: true });

obj.set('field', 'value');
await obj.save(null, { sessionToken: user.getSessionToken() });

const updatedAcl = obj.getACL().toJSON();
expect(updatedAcl).toEqual(originalAcl);
});

it('should allow explicit ACL modification on update', async () => {
await new Parse.Object('TestObject').save();
const schema = await Parse.Server.database.loadSchema();
await schema.updateClass(
'TestObject',
{},
{
create: { '*': true },
update: { '*': true },
ACL: {
'*': { read: true },
currentUser: { read: true, write: true },
},
}
);
const user = await Parse.User.signUp('testuser', 'p@ssword');
const obj = new Parse.Object('TestObject');
await obj.save(null, { sessionToken: user.getSessionToken() });

const customAcl = new Parse.ACL();
customAcl.setPublicReadAccess(false);
customAcl.setReadAccess(user.id, true);
customAcl.setWriteAccess(user.id, true);
obj.setACL(customAcl);
await obj.save(null, { sessionToken: user.getSessionToken() });

const updatedAcl = obj.getACL().toJSON();
expect(updatedAcl['*']).toBeUndefined();
expect(updatedAcl[user.id]).toEqual({ read: true, write: true });
});
});
4 changes: 2 additions & 2 deletions src/RestWrite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,8 @@ RestWrite.prototype.setRequiredFieldsIfNeeded = function () {
}
};

// add default ACL
if (
// add default ACL (only on CREATE, not UPDATE)
if (!this.query &&
schema?.classLevelPermissions?.ACL &&
!this.data.ACL &&
JSON.stringify(schema.classLevelPermissions.ACL) !==
Expand Down