Open
Conversation
… a date, drink count, and volume, by date. Days are partially using an offset - ie. a day is from 10am or noon until the next day.
…drinks by date on the trending page, along with the ability to see the drinks for each day. Implements 'bartendro standard time' to start at 10 am. This handles most of the cases when an event runs across midnight. If you enter Jan 1st as a begin date it will show you drinks from 10 am Jan 1st - 10 am Jan 2nd.
…plicate of the obvious drink size on the right side, but it seemed reasonable to me. ymmv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This responds to issue #105 Trending Drinks improvement. This adds code to report drinks by date, with links to see the drinks served for a particular date.
This assumes that a Day, for Bartendro, starts at 10am, which is a hack to deal with events which run across midnight.