Open
Conversation
patrickfweston
commented
Feb 19, 2018
| title: 'Be assigned Workbench Reviewer' | ||
| description: 'Users with this permissions may be assigned content to review via <em>Workbench Reviewer</em>.' | ||
| restrict access: FALSE | ||
| administer workbench reviewer: |
Owner
Author
There was a problem hiding this comment.
Unused at the moment, but will be used later when there are more Workbench Reviewer options / configuration.
Open
Collaborator
agentrickard
left a comment
agentrickard
left a comment
There was a problem hiding this comment.
The permissions part looks solid. The rest is best practice cleanup.
| ), | ||
| )) | ||
| ->setSetting('target_type', 'user'); | ||
| ->setSettings(array( |
Collaborator
There was a problem hiding this comment.
You can/should use short array syntax now [ ];.
| } | ||
|
|
||
| function workbench_reviewer_entity_field_access($operation, FieldDefinitionInterface $field_definition, AccountInterface $account, FieldItemListInterface $items = NULL) { | ||
| if ($field_definition->getName() == 'workbench_reviewer' && $operation == 'edit') { |
Collaborator
There was a problem hiding this comment.
It would be safer to make worbench_reviewer a constant, something like const WORKBENCH_REVIEWER_FIELD = 'workbench_reviewer'; That makes it easier to track (similar to how SASS uses vars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
drush pm-uninstall workbench_reviewer -ydrush en workbench_reviewer -yBe assigned Workbench ReviewerandAssign Workbench Reviewer.adminand your user name. Both should be allowable options.Be assigned Workbench Reviewer.Assign Workbench Reviewer.Note:
Once the module becomes more stable, update hooks will be used instead of uninstalling/installing the module.