fix(ExpandableSection): allow toggles proper dom structured headings #12037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitdallas
force-pushed
the
fix/8506-ExpandableSection-proper-headings
branch
from
5dab829 to
5da3aac
Compare
Contributor
|
Preview: https://pf-react-pr-12037.surge.sh A11y report: https://pf-react-pr-12037-a11y.surge.sh |
gitdallas
force-pushed
the
fix/8506-ExpandableSection-proper-headings
branch
from
5da3aac to
0e86f69
Compare
packages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsx
Show resolved
Hide resolved
packages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsx
Show resolved
Hide resolved
wise-king-sullyman
approved these changes
Oct 9, 2025
gitdallas
requested review from
a team,
mcoker and
rebeccaalpert
and removed request for
a team
thatblindgeye
requested changes
Oct 15, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just some tweaks for the headings used int he new example. Basically we should want the structure to be:
- An h3 for the example title
- An h4 for the titles used above each expandable section
- An h5 for the actual toggles in the new example
packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
approved these changes
Oct 15, 2025
gitdallas
force-pushed
the
fix/8506-ExpandableSection-proper-headings
branch
from
740eea7 to
c1f062c
Compare
…eadings Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
…ExpandableSectionWithHeading.tsx Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
…ExpandableSectionWithHeading.tsx Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
…ExpandableSectionWithHeading.tsx Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
…ExpandableSectionWithHeading.tsx Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
…ExpandableSectionWithHeading.tsx Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
…ExpandableSectionWithHeading.tsx Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
gitdallas
force-pushed
the
fix/8506-ExpandableSection-proper-headings
branch
from
c1f062c to
8680dee
Compare
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8506
including Eric's comment at the bottom of that story.
Example/doc and the DOM structure:
