Skip to content

Update README.md#74

Open
cassiaabarbosa wants to merge 1 commit intodevelopfrom
cassiaabarbosa-patch-1
Open

Update README.md#74
cassiaabarbosa wants to merge 1 commit intodevelopfrom
cassiaabarbosa-patch-1

Conversation

@cassiaabarbosa
Copy link
Copy Markdown
Collaborator

MR Description

Proposed changes

Describe your changes

Kind of Change

What kind of change does your code introduce? Put an x in the box that applies.
NOTE: Please do not create MRs with different purposes. Each MR must have a single purpose: Hotfix, New Feature, or Structural Change.

  • Hotfix.
  • New Feature.
  • Structural Change.

Checklist

Put an x in the boxes that apply.

This MR follows the base conventions of the project:

  • Does not add commented code.
  • Does not add code with print.
  • Documentation have been added / updated as needed.
  • Does not add repeated code, it's using Utils, Helpers classes and Extensions when necessary.
  • New Strings are located in *.strings file and the constants are generated by SwiftGen.
  • Delegates and Datasources are implemented outside the ViewController.
  • Tests have been added / updated as needed.
  • IBOutlets and delegates should be weak to avoid retain cycles.
  • Does not add duplicate images. (Check if the image already exists in the project)

Tests:

  • Tests are running at 70% coverage, with success and error cases for new features, bugs, and hotfixes.
  • Does not apply to this MR

Accessibility:

  • Accessibility have been implemented or updated.
  • Does not apply to this MR

Third-Party Libraries:

  • A new library? It's really neccessary? Explain why
  • Does not apply to this MR

Comments:

Comment here if necessary

Final checks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant