Added an optional environment variable S3_SERVER support#8
Open
AlexDumanskiy wants to merge 1 commit intopaulhammond:mainfrom
Open
Added an optional environment variable S3_SERVER support#8AlexDumanskiy wants to merge 1 commit intopaulhammond:mainfrom
AlexDumanskiy wants to merge 1 commit intopaulhammond:mainfrom
Conversation
|
I wouldn't force path-style URLs on all S3 implementations without a switch/option, as most implementations can do both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 is not limited to Amazon, there are third-party products, like enterprise storage systems, that provide it.
There are also smaller open source projects like Minio that implement S3.
I needed your script to work with a local Minio server, decided to make a PR with my humble changes.