Update kafka config and remove sarama-cluster #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MarkGreenPR
commented
Mar 9, 2022
MarkGreenPR
commented
- Add config files for testing kafka broker connections
- Add CREATE_TOPICS setting to env
- Remove sarama-cluster dependency
jscharber
requested changes
Mar 9, 2022
Contributor
jscharber
left a comment
jscharber
left a comment
There was a problem hiding this comment.
See my comments on k8s configs
| ports: | ||
| - containerPort: 9092 | ||
| env: | ||
| - name: KAFKA_PORT |
Contributor
There was a problem hiding this comment.
Do we not need the other env we talked about yesterday
| - name: KAFKA_ZOOKEEPER_CONNECT | ||
| value: zookeeper:2181 | ||
| - name: KAFKA_CREATE_TOPICS | ||
| value: logs:3:1 |
Contributor
There was a problem hiding this comment.
We run a proper cluster in prod so partitions and replication should be variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.