FISH-13058 Session bugs in availability mode: Missing JSESSIONIDVERSION and parallel requests Lead To Session Not Being Correctly Retrieved In Relaxed Mode#7984
Open
lprimak wants to merge 1 commit intopayara:mainfrom
Conversation
Member
|
Do you have a reproducer for this? |
Pandrex247
changed the title
JSESSIONIDVERSION Leads To Session Not Being Correctly Retrieved In Relaxed Mode
Contributor
Author
|
No :(. It happens once every couple of weeks in production and is a race condition |
lprimak
force-pushed
the
dont-require-version-in-relaxed-mode
branch
2 times, most recently
from
d016843 to
fd21274
Compare
…y retrieved in relaxed mode NOTE: This only happens on a first request that happens in parallel with session creation, so very sporadic bugfix: do not load older versions of a session in into the store - will override newer, correct session
lprimak
force-pushed
the
dont-require-version-in-relaxed-mode
branch
from
c52fedb to
7957173
Compare
lprimak
changed the title
JSESSIONIDVERSION Leads To Session Not Being Correctly Retrieved In Relaxed ModeJSESSIONIDVERSION and parallel requests Lead To Session Not Being Correctly Retrieved In Relaxed Mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y retrieved in relaxed mode
This only happens on a first request that happens in parallel with session creation, so very sporadic.
Another issue in the same realm. During parallel requests, older version of the session can overwrite a newer version. This fixes that by preventing older version from ever overriding a newer one.
Description
This is a bug fix. When a new session is being accessed in parallel with another thread creating it,
no version exists and thus session is not being found, or newer sessions being overwritten with older versions