FISH-13174 Reimplement change-master-broker for Deployment Groups#8060
Open
Pandrex247 wants to merge 11 commits intopayara:FISH-8649-Remove-Clustersfrom
Open
FISH-13174 Reimplement change-master-broker for Deployment Groups#8060Pandrex247 wants to merge 11 commits intopayara:FISH-8649-Remove-Clustersfrom
change-master-broker for Deployment Groups#8060Pandrex247 wants to merge 11 commits intopayara:FISH-8649-Remove-Clustersfrom
Conversation
…ode" This reverts commit f95312b.
… from JmsService" This reverts commit 8195ec3.
Most of these JMS classes have awful formatting!
…for Deployment Groups Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Reapplies our outstanding patches and adds a couple of fixes to close the streams Payara is warning about Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reimplements the
change-master-brokercommand and the supplemental classes to work with deployment groups.Also removes some more dangling GMS references.
Also pulls in the OpenMQ update as without it the logs are extremely hard to read.
This will likely need further iteration - if nothing else the
configure-jms-clustercommand also still needs readdingImportant Info
Blockers
N/A
Testing
New tests
None
Testing Performed
Testing has proven problematic - either my environment isn't set up correctly or even on vanilla
mainJMS clustering is broken ¯\_(ツ)_/¯ (or I'm missing some prerequisite steps).The option to change a master broker for a config appears in the admin console now for instances in a deployment group (it only showed for clusters before).
The command also appears under a deployment group in the REST management interface.
For setting up clusters, it helps to ensure that your /etc/hosts file (C:\Windows\System32\drivers\etc\hosts for Windows) is set up such that the FQDN and IP address is the first entry or at the very least before localhost and the other loopback entries.
Testing Environment
Windows 11, Zulu JDK 21.0.10, Maven 3.9.14
WSL OpenSUSE Tumbleweed
HyperV OpenSUSE Leap 16.0
Documentation
Later™
Notes for Reviewers
I have had to do some formatting on these classes - the indentation feels like it was done to offend me personally, I find them extremely hard to read as-is.